Handle exception when document.domain is set#382
Open
RobinQu wants to merge 2 commits intobrowserstate:masterfrom
Open
Handle exception when document.domain is set#382RobinQu wants to merge 2 commits intobrowserstate:masterfrom
RobinQu wants to merge 2 commits intobrowserstate:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If host page's
document.domainis set to another, access to iframes within the page will raise exceptions.To prevent such tragedy, a prior check for access privilege is necessary.
Hope I'm doing the right way.